Re: [PATCH] ext4: take i_mutex in ext4_symlink to eliminate a warning from ext4_truncate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 27, 2013 at 09:19:07PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> 
> After applied this commit (8e4061cb), we will get a warning from
> ext4_truncate when i_mutex isn't taken.  Here the assumption is that
> i_mutex should be taken when we do a truncation.  In ext4_symlink we
> could need to call ext4_truncate to trim some blocks beyond i_size, but
> the i_mutex isn't taken.

Hmm, and this is why I added the warning.  Even after looking your
patch, I'm having trouble finding the codepath that results in
ext4_truncate() getting called from __page_symlink().  Can you send
the stack trace from the WARN_ON, just so I can see what I missed?

Thanks,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux