On Wed, Mar 27, 2013 at 12:04:04PM +0100, Lukas Czerner wrote: > #define EXT4_MOUNT2_EXPLICIT_DELALLOC 0x00000001 /* User explicitly > specified delalloc */ > +#define EXT4_MOUNT_STD_GROUP_SIZE 0x00000002 /* We have standard group > + size of blocksize * 8 > + blocks */ This should be EXT4_MOUNT2_STD_GROUP_SIZE, and then all calls to set_opt, test_opt, etc. should be set_opt2, test_opt2, etc. As it turns out bit 0x0002 isn't used for flags in s_mount_opt family, so the other fix would be to move this definition to before EXT4_MOUNT_GRPID in ext4. However, the EXT4_MOUNT_* options should be reserved for options that are set via mount options, since we have support for setting bits in s_mount_opt via a table-driven approach (see how the mount_opt field in the struct mount_opts in fs/ext4/super.c is used). So for things that are set automatically, such as in this case, we should use a bit assignment for s_mount_opt2. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
