On Wed 13-03-13 23:04:40, Dmitry Monakhov wrote: > On Mar 13, 2013 11:57 AM, "Jan Kara" <jack@xxxxxxx> wrote: > > > > Hello Dmitry, > > > > I'm tracking down failure in xfstests test 274 (fallocate + ENOSPC > > testing). The problem I found (and that's really unrelated to the question > > I want to ask) is that if write beyond i_size fails, we truncate the file > > to i_size to remove any blocks that may have been allocated under the page > > by the write before it failed (think of blocksize < pagesize config). > > > > Now in this test the write fails because it needs to split unwritten > extent > > and there's no space for that and zeroing out is impossible because we are > > beyond i_size. And here comes my question: You disallowed zeroing of > > extents beyond i_size because fsck complains about those. Won't it be > > better to just add inode flag saying "this inode has blocks preallocated > > beyond i_size" and make fsck not complain about such blocks? IMHO that > > would catch 99% of corruptions as well and would let us solve the problem > > with ENOSPC on writes to preallocated space (plus it would simplify the > > kernel code). > Looks reasonable, but it will make kernel incompatible with old fsck. How > long does it takes to force customers to move to new version of fsck? First we'd have to add the support into fsck and once that is released, distros pick that up pretty quickly so after a month or two we can release it in the kernel. After all the fsck complaint isn't anything serious and it will happen only if we hit ENOSPC while splitting extents beyond i_size which is pretty rare. In those cases we would have to say to the complaining people to update e2fsprogs. > (Sorry for inconvenient email address , I'm on vacation till the end of the > week) No problem... Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
