Hello Dmitry, I'm tracking down failure in xfstests test 274 (fallocate + ENOSPC testing). The problem I found (and that's really unrelated to the question I want to ask) is that if write beyond i_size fails, we truncate the file to i_size to remove any blocks that may have been allocated under the page by the write before it failed (think of blocksize < pagesize config). Now in this test the write fails because it needs to split unwritten extent and there's no space for that and zeroing out is impossible because we are beyond i_size. And here comes my question: You disallowed zeroing of extents beyond i_size because fsck complains about those. Won't it be better to just add inode flag saying "this inode has blocks preallocated beyond i_size" and make fsck not complain about such blocks? IMHO that would catch 99% of corruptions as well and would let us solve the problem with ENOSPC on writes to preallocated space (plus it would simplify the kernel code). Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
