On Tue, Mar 12, 2013 at 10:14:20PM -0400, Theodore Ts'o wrote: > Oh, now I see my confusion. You're talking about retval being > different from the output of map->m_len. I was talking about retval > being often different from the *input* value of map->m_len. Ah, sorry for my bad expression. :-( > > I agree that the output of ext4_ext_map_blocks() and > ext4_ind_map_blocks() should be the same as map->m_len, and having a > BUG_ON there would make sense. But we can save those changes for > after -rc3 as a cleanup.... Actually, in my tree I use a WARN_ON() because I don't want to throw a kernel panic for user. I think it is too unfriendly. I will send a patch to change it after -rc3. Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html