On Sun, 10 Mar 2013, Theodore Ts'o wrote: > Date: Sun, 10 Mar 2013 22:26:35 -0400 > From: Theodore Ts'o <tytso@xxxxxxx> > To: Lukas Czerner <lczerner@xxxxxxxxxx> > Cc: linux-ext4@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/3] ext4: Use kstrtoul() instead of deprecated > simple_strtoul() > > On Fri, Mar 08, 2013 at 09:23:17AM +0100, Lukas Czerner wrote: > > In parse_strtoul() we're still using deprecated simple_strtoul(). Change > > that in favour of kstrtoul(). > > > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > Once you make this change, wouldn't it be better and even more > simplifying to replace the two places where we call parse_strtoul() > with kstrtoul()? > > - Ted I think that parse_strtoul() is still useful to have because we check the "max" value as well and return -EINVAL if it is exceeded. Removing it we would have to add the check to the callers where we're using is now, which seems unnecessary, especially since we might expect more users of the helper. -Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
