On 2013-03-08, at 2:24 AM, Jan Kara wrote: Won't it be cleaner (and not much > harder) if we always used ext2_dir_entry_2 in e2fsprogs and properly > did byte swapping of name_len only if FILETYPE feature isn't enabled? > I've checked and it would mean changing prototypes of like 8 > functions in ext2fs.h (or better provide new functions with struct > ext2_dir_entry_2 argument) which doesn't seem too bad... This > solution seems to be the least surprising to the users of libext2fs > (esp. if they do some scanning of directory blocks themselves or so). I've wanted to do this for a while as well. Or even go further and just deprecate support for filesystems that don't have the FILETYPE feature (which has been supported since Linux 1.2 or even earlier). Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
