Re: Mixup with name_len & file_type in e2fsprogs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 05, 2013 at 01:18:56PM +0100, Jan Kara wrote:
>   Hello,
> 
>   I was looking into a bug where application using e2fslib was complaining
> about file_type > 7. Now the problem is that this is on big endian system
> and ext2fs_dir_iterate() ends up calling ext2fs_dirent_swab_in() without
> EXT2_DIRBLOCK_V2_STRUCT flag set so name_len is treated as 2 byte and
> swapped.

Well, the application most be passing a pointer to treating a pointer
to a struct ext2_dir_entry as a struct dir_entry_2, right?  So it's
technically doing something wrong it sounds like.

The ext2_dir_entry_2 was probably a mistake, and it's hardly used at
all in e2fsprogs.  I wonder if we would be better off not trying to
support it at all, and perhaps adding better accessor functions for
struct ext2_dir_entry instead.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux