On Wed, Dec 05, 2012 at 12:41:25AM -0500, Theodore Ts'o wrote: > On Tue, Dec 04, 2012 at 04:56:02PM +0300, Dan Carpenter wrote: > > It looks good. > > > > Like I mentioned before Smatch doesn't understand > > ext4_has_inline_data() so it still complains later on in the > > function. But it's now obvious to a human reader that there won't > > be a NULL dereference. > > This is what I plan to fold into the patch. It should make it easier > for gcc to produce optimized code, as well as being easier to > understand. Hopefully this should also keep smatch happy. > Yeah, moving the check for (inode_bh == NULL) forward is nice. Thanks. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
