On Tue, Dec 04, 2012 at 09:25:45PM +0800, Tao Ma wrote: > Hi Dan, > Thanks for the report. Can you check whether this patch > works for you? > It looks good. Like I mentioned before Smatch doesn't understand ext4_has_inline_data() so it still complains later on in the function. But it's now obvious to a human reader that there won't be a NULL dereference. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html