On Sat 03-11-12 21:30:21, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Just use WARN_ON rather than an if containing only WARN_ON(1). > > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > - if (e) WARN_ON(1); > + WARN_ON(e); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Thanks. Added into my tree. Honza > --- > fs/ext3/inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c > index 7e87e37..b176d42 100644 > --- a/fs/ext3/inode.c > +++ b/fs/ext3/inode.c > @@ -1071,8 +1071,7 @@ struct buffer_head *ext3_getblk(handle_t *handle, struct inode *inode, > * mapped. 0 in case of a HOLE. > */ > if (err > 0) { > - if (err > 1) > - WARN_ON(1); > + WARN_ON(err > 1); > err = 0; > } > *errp = err; > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
