There is no reason to use static there, and it will cause issues when reading /proc/fs/ext4/<partition>/options concurrently. Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx # 3.4+ --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The problem is easy to reproduce, for example running: $ cat /proc/fs/ext4/<partition>/options > options.txt $ while diff /proc/fs/ext4/<partition>/options options.txt; do true; done - And concurrently on another terminal: $ while diff /proc/fs/ext4/<partition>/options options.txt; do true; done One of the diff loops will get incomplete options contents because of the issue, and exit. I also believe the same problem is the cause of the following bug: https://bugs.launchpad.net/bugs/1053019, that happened while running test 234 from xfstests. diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 41598ee..975405c 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1748,7 +1748,7 @@ static inline void ext4_show_quota_options(struct seq_file *seq, static const char *token2str(int token) { - static const struct match_token *t; + const struct match_token *t; for (t = tokens; t->token != Opt_err; t++) if (t->token == token && !strchr(t->pattern, '=')) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
