On 09/12/2012 05:20 PM, Eric Sandeen wrote: > On 9/12/12 6:15 PM, Brad Figg wrote: >> I'm going to be doing some new runs so anything I find will be reported. > > Dave Chinner also pointed out that i.e. > > http://kernel.ubuntu.com/beta/testing/test-results/statler.2012-09-11_22-42-47/xfstests/default/control > > seems to redefine, re-group, exclude etc various tests, and is taking "intelligence" out of the test suite itself. > > I'd be wary of that; xfstests is dynamic - things get fixed, tests get added, groups changed, etc. > > If you hard code for example "this test is for xfs" somewhere else, you might miss updates which add coverage. > > Another example : > > #'197' : ['xfs'],# This test is only valid on 32 bit machines > > but the test handles that gracefully: > > bitsperlong=`src/feature -w` > if [ "$bitsperlong" -ne 32 ]; then > _notrun "This test is only valid on 32 bit machines" > fi > > In general any test should be runnable; it may then issue 'not run' for some reason or other, but there's no harm in it - not as much harm as skipping regression tests because some config file got out of date... > > and: > > #'275' : ['generic'] # ext4 fails > > but I just fixed that one up, and it should pass now. Who will update the 3rd party config? > > Failing tests absolutely should be run as well. That information is as valuable as passing tests. The goal is getting a complete picture, not just a series of "pass" results. :) > > -Eric > Eric, Thanks for taking the time to point this out. We will adjust our testing accordingly. We initially tried to run xfstest against ext2, ext3, ext4, xfs and btrfs. We are also trying to get these tests to run on several different kernel versions as you can see from our test results. We were running into issues on different kernels and various file-systems while getting our act together, we did this as a band-aid. I accept that we have some things to learn w.r.t. running this test suite. We will work to run the xfstests "as is" without any outside "intelligence". We do recognise that is a dynamic set of tests that people are adding to regularly. I am not attempting to get just a series of "pass" results. If that were my goal I could accomplish it much easier and would not have engaged with the community on the mailing list. We want to help where we can and will accept constructive criticism. Brad -- Brad Figg brad.figg@xxxxxxxxxxxxx http://www.canonical.com -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
