On Fri, Mar 23, 2012 at 06:33:31PM -0400, Ted Ts'o wrote: > It would then be very easy to build iterators on *top* of > find_first_zero() and find_first_set(), and in fact this could be used > to replace some of the places where we are using a sorted list (i.e., > the badblocks list). So that sounds like a good idea, and I can > definitely think of some places where we could use that code today. > > So I plan to pull in your patch series and then we can further enhance > this with iterator support afterwards. Sami, if you'd be interested > in implementing iterators, that would be great! Just to be on the same page, what is the motivation for iterators? Is it performance, making the code cleaner or facilitating further functionality? If it's driven by performance concerns, it would be good to first have a case where they cause performance problems. Otherwise it would be good to first figure out a program in the e2fsprogs suite that exercises (or could exercise) the code in question, just for testing. My work on inode allocation was actually entirely driven by a friend's observation that resize2fs took 16 CPU hours to shrink a filesystem. Profile-guided optimization is something I generally do a lot, but I'm not averse to doing other kinds of useful coding tasks for useful open source projects. Sami -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
