On 03/20/2012 10:46 AM, Joe Perches wrote: > On Tue, 2012-03-20 at 10:25 +0100, Jiri Slaby wrote: >> On 03/20/2012 10:21 AM, Joe Perches wrote: >>> the ath5k pr_ conversion patches are to >>> standardize prefixes and to reduce code size by >>> centralizing tests. >> >> What is the "standard" prefix? > > KBUILD_MODNAME Instead, we should switch as many printks to dev_* and similar as possible, right? They are standard and provide a good interface for extensions: one has a device to work with. This is something what pr_* does not offer. For that reason it's not worth it. >>> https://lkml.org/lkml/2012/3/18/121 >>> https://lkml.org/lkml/2012/3/18/123 >>> https://lkml.org/lkml/2012/3/18/124 >>> I happen to like 30K/10+% code size reductions. >> Obvious question: what speed reduction does this bring? > > Anyone looking for speed impacts in logging > messages is looking in the wrong place. Ok, I finally found some time to look into the changes properly. I was confused by Adrian's note that you moved a debug check to an external function. But that is not true. > btw: it's effectively 0. Frankly, moving the debug code to a separate function should make the code rather faster. By moving the unlikely code out of the instruction cache. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
