On Fri, Dec 30, 2011 at 07:00:02PM +0800, Yongqiang Yang wrote: > +void free_flex_gd(struct ext4_new_flex_group_data *flex_gd) This should be static, so we don't leak symbols that don't begin with "ext4_" into kernel namespace. I've checked and future users of this function are in fs/ext4/resize.c, so there's no reason for this not to be non-static. (A good thing to do while doing development is to run "nm ext4.ko" and check for exported symbols that you aren't expecting.) Again, I'll fix this as a minor nit. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
