On Sat, Dec 31, 2011 at 10:40:24AM -0700, Andreas Dilger wrote: > The main issue I have with this patch is that the series starts by > adding a bunch of unused functions, and only wires them I to the > existing resize code at the very end. > > A better approach would be to have the early patches refactor the > existing functions so that they are used by the current resize code, > and the new resize functionality is enabled at the end. > > That allows verifying that the existing code continues to work > through the entire series, and that the functions being added > actually work properly even before the new ioctl is added. I agree with Andreas that in general this is better way to ago, although as long as regression testing is done with both the new (v1.42) resize2fs as well as the old (v1.41.x) resize2fs, it's OK. (Regressions with the v1.41.x resize2fs are just as important because many people will be upgrading to the new kernel without necessarily upgrading their e2fsprogs userspace programs, and we can't let them break.) I've done some quick regression testing using both the old and new resize2fs programs, however, and it looks good. I'm going to take a quick final scan over the patches, but I think they are ready for inclusion. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
