On Fri, 4 Nov 2011 at 20:50, Niu wrote: > diff --git a/lib/ext2fs/ext2fsP.h b/lib/ext2fs/ext2fsP.h > index b182d7f..82e1ba0 100644 > --- a/lib/ext2fs/ext2fsP.h > +++ b/lib/ext2fs/ext2fsP.h > @@ -11,6 +11,8 @@ > > #include "ext2fs.h" > [...] > --- a/lib/ext2fs/finddev.c > +++ b/lib/ext2fs/finddev.c > @@ -34,6 +34,7 @@ > > #include "ext2_fs.h" > #include "ext2fs.h" > +#include "ext2fsP.h" On the very real chance of making a fool of myself: if ext2fsP.h includes ext2fs.h and now finddev.c will include ext2fsP.h - shouldn't we omit the '#include "ext2fs.h"' in finddev.c (and namei.c) now? I guess the compiler/preprocessor will figure this out, just wondering about code cleanliness. Then again we have names like 'ext2_fs.h' and 'ext2fs.h', I guess only an insider will know the difference :-) Christian. -- BOFH excuse #97: Small animal kamikaze attack on power supplies -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
