On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote: > Quiets the sparse noise: > > warning: symbol 'ext3_initxattrs' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > Cc: Jan Kara <jack@xxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx> Here applies the same comment as to the ext2 patch - not in current Linus' kernel AFAICS. Honza > > --- > > diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c > index 3c218b8..3f065f8 100644 > --- a/fs/ext3/xattr_security.c > +++ b/fs/ext3/xattr_security.c > @@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name, > name, value, size, flags); > } > > -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array, > +static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array, > void *fs_info) > { > const struct xattr *xattr; -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html