On Fri, Sep 16, 2011 at 2:35 PM, Yongqiang Yang <xiaoqiangnk@xxxxxxxxx> wrote:
> On Fri, Sep 16, 2011 at 2:52 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>> On Thu, Sep 15, 2011 at 8:57 PM, Ted Ts'o <tytso@xxxxxxx> wrote:
>>> On Thu, Sep 15, 2011 at 07:01:47PM +0300, Amir Goldstein wrote:
>>>> > + { E2P_FEATURE_COMPAT, EXT2_FEATURE_COMPAT_EXCLUDE_BITMAP,
>>>> > + "snapshot" },
>>>>
>>>> The feature name should read "exclude_bitmap".
>>>> This is a COMPAT feature which should be set by default on every mkfs.ext4.
>>>> The "has_snapshot" (or "snapshots") feature is a RO_COMPAT feature, which
>>>> can be turned on and off, depending on whether you want to enable or
>>>> disable snapshots.
>>>
>>> Yeah, I was trying to use a name which would be a bit more descriptive
>>> than "exclude_bitmap", but I agree that will get very confusing with
>>> the "has_snapshot" feature name.
>>>
>>> - Ted
>>>
>>
>> maybe we can simply call it snapshot_bitmap, if it pleases everyone ;-)
> active_snapshot_bitmap will be clearer.:-)
clearer to who?
this name is printed by "tune2fs -l"
potential readers of this output, who did not read the documentation
first, are just as likely to know what
"exclude_bitmap" means as when they read "resize_inode" or "flex_bg",
but at least "snapshot_bitmap"
will give them a clue.
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
