On Thu, Sep 15, 2011 at 8:57 PM, Ted Ts'o <tytso@xxxxxxx> wrote:
> On Thu, Sep 15, 2011 at 07:01:47PM +0300, Amir Goldstein wrote:
>> > + { E2P_FEATURE_COMPAT, EXT2_FEATURE_COMPAT_EXCLUDE_BITMAP,
>> > + "snapshot" },
>>
>> The feature name should read "exclude_bitmap".
>> This is a COMPAT feature which should be set by default on every mkfs.ext4.
>> The "has_snapshot" (or "snapshots") feature is a RO_COMPAT feature, which
>> can be turned on and off, depending on whether you want to enable or
>> disable snapshots.
>
> Yeah, I was trying to use a name which would be a bit more descriptive
> than "exclude_bitmap", but I agree that will get very confusing with
> the "has_snapshot" feature name.
>
> - Ted
>
maybe we can simply call it snapshot_bitmap, if it pleases everyone ;-)
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
