On Thu, Sep 15, 2011 at 05:34:41PM -0600, Andreas Dilger wrote: > > Darrick and I discussed zeroing the checksum fields, but then there is a > race with other threads accessing the same structure. What race are you worried about? The moment you modify some part of the data structure, the checksum is going to be wrong. This is true whether you zero out the checksum field before you do the calculations or not. > If we went to a crc32c LSB for filesystems with RO_COMPAT_CSUM it would > be possible to change how it is computed. Since we have freedom to move > the checksum field now, why have the added complexity to do zeroing of > the field or two chunks? Why is zero'ing out the field complex? It's a single line of code.... It's certainly easier than doing it in two chunks, and there will be some data structures (the block group descriptors at the very least) where zero'ing the checksum is definitely going to be the easier way to go. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
