Re: [PATCH 1/2] libext2fs: add metadata checksum and snapshot feature flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 15, 2011 at 05:09:13PM -0600, Andreas Dilger wrote:
> 
> I thought it would be better to move s_checksum to be the last field in the
> superblock to avoid multiple calls to the CRC function? 

Did you see my comment about just zero'ing the checksum field before
running the CRC?  We're going to have to do that for other data
structures, such as the inode structure, and it's what we do with the
block group descriptor checksum.  Might as well do that everywhere for
consistency's sake.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux