On Wed 22-06-11 10:22:35, Ted Tso wrote: > On Wed, Jun 22, 2011 at 01:54:25AM +0200, Jan Kara wrote: > > ext4_page_mkwrite()... Ted, what happened to that patch. Should I resend > > it? > > So assuming I fix the refcounting issue in fs/ext4/page_io.c (which I > will do not dropping the page's refcount until after the workqueue > finishes its job), does your patch need changing, or is it a matter of > fixing the commit description? Looking into patchwork (http://patchwork.ozlabs.org/patch/97924/) I see the discussion of two issues (page refcounting and page_mkwrite got mixed). I see the patch just needs fixing commit description because it's no longer accurate after "stable page under writeback" changes went it. I'll send you a patch with updated changelog in a minute. > In any case, this dragged got out, and it's late in -rc cycle for 3.0, > so I was planning on queuing this for the next merge window. (Sorry > for that, this was mostly due to my not having enough time to really > dive into the issues involved.) No problem. Just we have to somehow coordinate with Christoph... Either he can avoid touching ext4 and merge his patch set after you merge my patch or he can take my patch instead of his ext4 change. Since my patch touches only ext4_page_mkwrite() there's not a high risk of collision. The latter would seem easier for both of you to me but I don't really care. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
