On Mon, Jun 13, 2011 at 4:41 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, 11 Jun 2011 02:36:01 -0700 > Manish Katiyar <mkatiyar@xxxxxxxxx> wrote: > >> Allocate a slab cache for jbd transaction allocations. It may help to test >> various memory failure scenarios. > > This doesn't seem terribly useful to me. That's truly ancient code and > the change rate is really low. If there were problem in there then > we'd already know about them. And the allocation frequency for these > objects is very low. > > If you had some deeper reason for making this change, please describe > it. For example, were you chasing some bug? Hi Andrew, I was doing similar changes for jbd2, hence did it for jbd too. The changes for jbd2 were done so that we can use the fault injection framework to introduce/test ENOMEM situations from the journal transaction allocation layer and test how well the callers (ext4 code in particular) deal with such situations and fix them if required. -- Thanks - Manish -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
