On Sat, 11 Jun 2011 02:36:01 -0700
Manish Katiyar <mkatiyar@xxxxxxxxx> wrote:
> Allocate a slab cache for jbd transaction allocations. It may help to test
> various memory failure scenarios.
This doesn't seem terribly useful to me. That's truly ancient code and
the change rate is really low. If there were problem in there then
we'd already know about them. And the allocation frequency for these
objects is very low.
If you had some deeper reason for making this change, please describe
it. For example, were you chasing some bug?
> +static int journal_init_transaction_cache(void)
> +{
> + J_ASSERT(jbd_transaction_cache == NULL);
> + jbd_transaction_cache = kmem_cache_create("jbd_transaction",
> + sizeof(transaction_t),
> + 0, 0, NULL);
We have a KMEM_CACHE helper macro for this. It proved useful at the
time, when we were changing the kmem_cache_create() arguments fairly
often. It's less useful now.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
