> @@ -1577,6 +1589,7 @@ static int ext3_ordered_writepage(struct page *page, > if (ext3_journal_current_handle()) > goto out_fail; > > + trace_ext3_ordered_writepage(inode, page); > if (!page_has_buffers(page)) { > create_empty_buffers(page, inode->i_sb->s_blocksize, > (1 << BH_Dirty)|(1 << BH_Uptodate)); Any reason why writepage() takes inode while all other page operations take only the page pointer? I see ext4 does this as well but still we don't have to be *that* compatible :). Otherwise the patch looks OK. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html