On 5/6/11 6:36 AM, Lukas Czerner wrote: > On Fri, 6 May 2011, Theodore Tso wrote: > >> I don't really see the point to removing redundant keywords >> like this. To my mind, it's like fixing whitespaces. If we are >> making changes to that part of the code, it's good to fix it, >> and I'd rather not introduce such things in new code, but >> as far as fixing code like this, i don't think an extra "extern" >> is that harmful that it's worth fixing up. >> >> What do other people think? > > Agreed! And since I am going to make some changes in lazyinit code anyway, > I can very well make that change (and of course give Robin the credit for > it:). > > On the other hand I do not see a *huge* problem with commits like that, but > it is just additional unnecessary commit. Usually people complain that > git blame need some more digging with commits like this changing > otherwise perfectly sane code, but when one is going to make that change > when making some changes "at that area" it would mess up git blame > anyway. > > Thanks! > -Lukas FWIW, I had noticed this too, and there is another one in fsync.c: fsync.c:extern int ext4_flush_completed_IO(struct inode *inode) so, next time someone touches that code... ;) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
