I don't really see the point to removing redundant keywords
like this. To my mind, it's like fixing whitespaces. If we are
making changes to that part of the code, it's good to fix it,
and I'd rather not introduce such things in new code, but
as far as fixing code like this, i don't think an extra "extern"
is that harmful that it's worth fixing up.
What do other people think?
-- Ted
On May 6, 2011, at 4:19 AM, Robin Dong wrote:
> Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx>
> ---
> fs/ext4/ialloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 21bb2f6..ace7aef 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1235,7 +1235,7 @@ unsigned long ext4_count_dirs(struct super_block * sb)
> * inode allocation from the current group, so we take alloc_sem lock, to
> * block ext4_claim_inode until we are finished.
> */
> -extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
> +int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
> int barrier)
> {
> struct ext4_group_info *grp = ext4_get_group_info(sb, group);
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
