On Fri, Feb 4, 2011 at 7:53 AM, Jan Kara <jack@xxxxxxx> wrote: > On Sat 29-01-11 21:40:03, Manish Katiyar wrote: > Hi Manish, > >> Have we reached on any conclusion yet on the function name which I can >> use to send my updated patch ? My preference from the above list is to >> use ext4_journal_start_nofs() as that seems the closest match, but I >> would like hear the conclusion from experts. > How about "ext4_journal_start_tryhard()"? I don't like "nofs" because > the fact whether we use GFP_NOFS is separate from the fact whether we are > able to handle memory allocation failure. Hi Jan, Sorry for taking so long to respond to this. I'm sending the updated set of patches after incorporating your previous comments. As suggested I have added a wrapper routine ext4_journal_start_tryhard() for the transaction allocation which can't fail and does its allocation using GFP_NOFS. Regular ext4_journal_start() uses GFP_KERNEL. -- Thanks a lot - Manish -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
