On Sat 29-01-11 21:40:03, Manish Katiyar wrote: Hi Manish, > Have we reached on any conclusion yet on the function name which I can > use to send my updated patch ? My preference from the above list is to > use ext4_journal_start_nofs() as that seems the closest match, but I > would like hear the conclusion from experts. How about "ext4_journal_start_tryhard()"? I don't like "nofs" because the fact whether we use GFP_NOFS is separate from the fact whether we are able to handle memory allocation failure. In fact, your patch set should keep calling kzalloc() with GFP_NOFS in all cases to avoid new recursions into the filesystem (which could cause deadlocks - changing that would need a separate audit if we care enough). Just the retrying logic should be influenced by your work. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
