On Sat, Feb 26, 2011 at 08:21:47PM +0200, Amir Goldstein wrote: > Hi guys, > > I have just realized something very disturbing - > that orphan cleanup is not being skipped on readonly mount of ext4/ext3. > > I know that journal recovery is done on readonly mount > and there is problem with that, since nothing happens > in the fs level. > > But orphan cleanup deletes inodes and frees blocks and that > could be very bad for some RO_COMPAT features, SNAPSHOT > and BIGALLOC to name two. Yes, good point. Fortunately it won't be a problem for the BIGALLOC feature, since other changes in the superblock will cause the kernel's sanity checks to refuse to mount it until we teach future kernels how not to freak out when s_blocks_per_group > blocksize * 8, for example. But yes, this is something we should fix. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
