Hi guys, I have just realized something very disturbing - that orphan cleanup is not being skipped on readonly mount of ext4/ext3. I know that journal recovery is done on readonly mount and there is problem with that, since nothing happens in the fs level. But orphan cleanup deletes inodes and frees blocks and that could be very bad for some RO_COMPAT features, SNAPSHOT and BIGALLOC to name two. I am not so sure why orphan cleanup is so important for readonly mount in the first place? Now the damage has been done, because current stock kernels will corrupt future fs with SNAPSHOT and BIGALLOC features (unless Ted backs up from the decision to make BIGALLOC RO_COMPAT...) I think that we should skip orphan cleanup on readonly mount ASAP and try to push this fix to as many stable/maint kernels out there, before the problem gets worse. Can anyway see a problem with skipping orphan cleanup? Maybe there is a problem with later remount read-write? I would spend time more time to investigate these questions, but I find this problem too disturbing and urgent to wait until I find the time to do so... Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
