On Mon, Feb 7, 2011 at 3:23 PM, Ted Ts'o <tytso@xxxxxxx> wrote: > On Sat, Jan 29, 2011 at 09:40:34PM -0800, Manish Katiyar wrote: >> >> Any feedback on this ? > > The patch looks good, but it doesn't fix bug #26752. > > The root cause of that bug is the fact that ext4_sync_fs() and > ext4_put_super() assumes that sbi has been initialized. Hmm.. Actually I was looking at generic_super_shutdown() which I thought would call ext4_put_super() only if sb->root is set, and since I was setting sb->root explicitly to NULL in my patch in case of failures. -- Thanks - Manish -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
