On Mon, 2011-02-07 at 11:58 -0600, Eric Sandeen wrote: > On 02/07/2011 09:59 AM, Ted Ts'o wrote: > > On Sun, Feb 06, 2011 at 09:33:36PM -0500, Ted Ts'o wrote: > >> > >> Hey Eric, > >> > >> One question about this patch. You are currently using a hashed array > >> of size 37 for the waitqueue; what about using a similarly sized > >> hashed array for the aio_mutex? We only take it for unaligned > >> mutexes, and I'm trying to work on reducing the size of ext4 inode, > >> since it gets rather large in the inode cache.... > >> > >> - Ted > > > > Like this.... I also changed to_ioend_wq() and ioend_wq[] to be > > ext4_ioend_wq() and ext4__ioend_wq[], since they are now global > > variables. > > > > Looks fine to me, thanks, feel free to put an akpm-style comment > in the commit about what you fixed up. > > -Eric Ted, Eric, If it matters, you could add reviewed-by: Mingming Cao <cmm@xxxxxxxxxx> from me. The modified version looks fine with me. Mingming > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
