On Fri, Nov 19, 2010 at 09:10:07AM -0500, Christoph Hellwig wrote: > On Fri, Nov 19, 2010 at 09:02:03AM -0500, Ted Ts'o wrote: > > Deterministic TRIM is an option. It doesn't have to be implemented. > > For reasonable use it has to. That rationale for it is pretty clearly > outline in ftp://ftp.t10.org/t10/document.08/08-347r1.pdf. > I think the author of that slide deck was being a little hysterical. In nearly all of these cases, if the file system is comptently implemented (i.e., you don't do a trim on anything but a deleted file block, and _only_ when you know the deleted is committed, and only the filesystem --- not non-privileged users --- are allowed to use the TRIM command), there's no issue. One case where I'll admit he may have a point is where you are using software RAID, where if the TRIM is not determinstic, the only thing which is safe to do is a TRIM of an entire RAID stripe. If the file system doesn't know about the RAID geometry, then yes, in that case determinstic TRIM is better --- although even then, it implies that you have to rebuild the raid strip after you do a TRIM, which a RAID-oblivious file system wouldn't do, and so you would still be toast. In the case of incompetently implemented, or buggy file systems, I'll agree that non-determinstic trim offers a bunch of pitfalls --- but so does deterministic trim in many of these cases. For example, one of their disaster scenarios was where you do a trim on an allocated block, and then proceed to read from that allocated block. That could only happen if the trim happened but the delete didn't commit. But in that case, the fact that data blocks would disappear for a non-deleted file is also a disaster, and means the file system wasn't implemented correctly. The other case where non-determinstic trim could get you in trouble is if (a) you give a user direct read access to a partition of the disk, without any file system as an intermediary, and (b) you allow that non-privileged user to issue TRIM commands to that partition. In that case, it's possible that non-deterministic trim might allow you access to non-deleted blocks in other partitions. But this goes back to my observation that you're totally safe so long as TRIM is a privileged operation and/or only allowed to be executed by the file system. So yeah, deterministic trim is tricker, and you have to be more careful, especially if you're using RAID, but it's not inherently a disaster... - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
