Re: [PATCH] mke2fs: skip alignment questioning if -F specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mar 12, 2010, at 10:17 AM, Eric Sandeen wrote:

> Andreas Dilger wrote:
>> On 2010-03-11, at 19:48, tytso@xxxxxxx wrote:
>>> On Mon, Mar 01, 2010 at 01:53:09PM -0600, Eric Sandeen wrote:
>>>> RH bug 569021 - mke2fs insists on user interaction even if stdin is
>>>> not a tty and -F is passed
>>>> 
>>>> This is just a warning, -F should easily override it.
>> 
>> Since this is just a warning, do we really need to have "-F" at all?  I
>> dislike requiring "-F" on common actions, because it means that it will
>> commonly be used, but may accidentally override some unintended problem.
>> 
>> We've lived without block device alignment until now, and it seems
>> somewhat unpleasant that mke2fs may start failing (if -F is not given)
>> for situations where it previously worked just fine.
> 
> Well, that's a good point, dropping the -F requirement is fine with me too,
> I guess.
> 
> Ted do you want to just toss in:
> 
> -		if (!force)
> -			proceed_question();


Yeah, I'll just make the change on my end.


-- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux