On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote:
> The "offset" member in ext4_io_end holds bytes, not
> blocks, so ext4_lblk_t is wrong - and too small (u32)
>
> This caused the testcase "Possible ext4 data corruption
> with large files and async I/O" sent by Giel to fail when it
> wrapped around to 0.
>
> Also fix up the type of arguments to
> ext4_convert_unwritten_extents(), it gets ssize_t from
> ext4_end_aio_dio_nolock() and ext4_ext_direct_IO()
>
> Reported-by: Giel de Nijs <giel@xxxxxxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
So I was going to submit this patch to Linus, but the last two times
I've run xfsqa ("xfsqa -g quick" and "xfsqa -g auto"), test #126 has
failed. If I run the test stand-alone, it passes. It's a bit of a
head-scratcher. I'm currently backing out the patch and trying to do
an xfsqa -g auto run to make sure this was something that had crept in
before applying this patch, so this may very well not be this patch
--- I certainly can't see anything wrong with it. But I thought I
would give a heads up....
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
