Re: Please reserve INCOMPAT flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-01-24, at 12:48, tytso@xxxxxxx wrote:
On Sun, Sep 06, 2009 at 11:25:46AM +0200, Andreas Dilger wrote:
in addition to the data-in-dirent INCOMPAT flag Rahul sent the patches
for last week, I would like to ensure that we also have the INCOMPAT
flag for large EA-in-inode flag reserved.  This patch is going into
testing at one of our large customers, and I want to make sure that
we don't accidentally get a conflicting INCOMPAT flag assignment.

#define EXT4_FEATURE_INCOMPAT_EA_INODE	0x0400
#define EXT4_FEATURE_INCOMPAT_DIRDATA   0x1000

#define EXT4_EA_INODE_FL	0x00200000 /* Inode used for large EA */

Reserving... but stupid question, do you know if anyone is currently
using the inode flag 0x00100000?  I want to make sure that's properly
documented and reserved.


It doesn't seem that ext2/3/4 are using the 0x00100000 value itself, but it seems the VFS is using this value for FS_DIRECTIO_FL. Should we reserve this in the ext4 flags also, to avoid collisions? I'm not sure what that flag is for, possibly to force all IO to the file to be uncached?

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux