On Wed, Sep 02, 2009 at 05:28:11PM -0600, Andreas Dilger wrote: > On Sep 02, 2009 16:43 -0500, Eric Sandeen wrote: > > ext2fs_bg_flags_clear shouldn't take an unused bg_flags argument > > if its purpose is to clear -all- flags. That just makes people > > like me call it for the wrong purpose ;) > > I'd pointed this out when the code was originally submitted. > That said, I'd prefer a function which allows clearing > individual flags, rather than all of them. It is possible to > call it with ~0 to clear all of the flags. Agreed; if we want to have a function which clears all of the flags, it should be named something like ext2fs_bg_flags_zap(), or some such. It would be confusing for ext2fs_bg_flags_clear() and ext2fs_bg_flags_set() not to be symmetric. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
