Re: [PATCH] e2fsprogs: remove misleading argument from ext2fs_bg_flags_clear

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 02, 2009  16:43 -0500, Eric Sandeen wrote:
> ext2fs_bg_flags_clear shouldn't take an unused bg_flags argument
> if its purpose is to clear -all- flags.  That just makes people
> like me call it for the wrong purpose ;)

I'd pointed this out when the code was originally submitted.
That said, I'd prefer a function which allows clearing
individual flags, rather than all of them.  It is possible to
call it with ~0 to clear all of the flags.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux