On Tue 21-07-09 17:35:48, Theodore Tso wrote: > On Tue, Jul 21, 2009 at 09:19:46AM -0700, Andrew Morton wrote: > > > > It's odd that sb->s_first/s_maxlen are 32-bit and > > journal->j_first/j_last are unsigned long. > > > > These things will only ever be 32-bit unless we change the journal > > superblock. > > In general, if there is any use of "unsigned long" in fs/ext[34], it's > probably a bug. This is because ulong is 32-bits on x86, and 64-bits > on x86_64, so it just wastes memory space on 64-bit platforms. The > one exception to this is if the field in question is used by the > standard bitops functions, which only functions correctly on "unsigned > long". That's a good point. I'll write a cleanup patch at least for the obvious offenders. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
