On Mon, Jun 22, 2009 at 09:42:25AM -0700, Curt Wohlgemuth wrote:
> Hi Ted:
>
> I think the following patch is sufficient. It explicitly sets the aops to
> ext4_writeback_aops if there is no delayed allocation and no journal.
>
> I tested the locale-gen example with all combinations of
>
> data=writeback
> data=ordered
> data=journal
> <no journal at all>
>
> and
>
> delalloc
> nodelalloc
>
> and it works correctly now. The paths for writeback seem fine to me for an
> inode w/o a journal.
>
>
> Signed-off-by: Curt Wohlgemuth <curtw@xxxxxxxxxx>
> ---
> --- 2.6.26/fs/ext4/inode.c.orig 2009-06-09 20:05:27.000000000 -0700
> +++ 2.6.26/fs/ext4/inode.c 2009-06-22 08:55:13.000000000 -0700
> @@ -3442,15 +3442,12 @@ static const struct address_space_operat
>
> void ext4_set_aops(struct inode *inode)
> {
> - if (ext4_should_order_data(inode) &&
> - test_opt(inode->i_sb, DELALLOC))
> + if (test_opt(inode->i_sb, DELALLOC))
> inode->i_mapping->a_ops = &ext4_da_aops;
> else if (ext4_should_order_data(inode))
> inode->i_mapping->a_ops = &ext4_ordered_aops;
> - else if (ext4_should_writeback_data(inode) &&
> - test_opt(inode->i_sb, DELALLOC))
> - inode->i_mapping->a_ops = &ext4_da_aops;
> - else if (ext4_should_writeback_data(inode))
> + else if (ext4_should_writeback_data(inode) ||
> + EXT4_JOURNAL(inode) == NULL)
> inode->i_mapping->a_ops = &ext4_writeback_aops;
> else
> inode->i_mapping->a_ops = &ext4_journalled_aops;
>
>
I looked at the patch in detail and I guess we should instead force
a data=writeback mode if the filesystem is created without a journal.
I am not sure what whould be the meaning of data=ordered/data=journal
without a journal. So if we find that file system doesn't have a journal
then either we should update the default mount option in the filesystem
to be of data=writeback. Also if the user tried to mount with
data=ordered or data=journal we should print appropriate message and
force ourself to data=writeback.
Once we have data=writeback set then ext4_set_aops will handle the case
properly.
-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
