Hi Curt, Thanks for your analysis of the bug. The reason for the strange logic in ext4_set_aops() is because at the moment the code doesn't support the combination of data=journalled && delalloc. That's why it was explicitly checking for ext4_should_order_data() and ext4_should_writeback_data(). We have a check for this in ext4_fill_super(), so your patch should be safe, since the combination of ext4_should_journal_data && test_opt(inode->i_sb, DELALLOC) should never happen. As to your question of whether the nodelalloc and nojournal case should really be ext4_journalled_aops, I suspect ext4_writeback_aops makes more sense. I haven't audited all of the code paths to make sure they DTRT in the non-journalled case yet, though. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
