> ext4_fill_super() is no longer called by read_super(), and it is no > longer called with the superblock locked. The > unlock_super()/lock_super() is no longer present, so this comment is > entirely superfluous. Yes, the comment seems to be out of date. Acked-by: Jan Kara <jack@xxxxxxx> Honza > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> > --- > fs/ext4/super.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index e20ff9c..e0b0c9f 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -2806,14 +2806,6 @@ no_journal: > goto failed_mount4; > }; > > - /* > - * akpm: core read_super() calls in here with the superblock locked. > - * That deadlocks, because orphan cleanup needs to lock the superblock > - * in numerous places. Here we just pop the lock - it's relatively > - * harmless, because we are now ready to accept write_super() requests, > - * and aviro says that's the only reason for hanging onto the > - * superblock lock. > - */ > EXT4_SB(sb)->s_mount_state |= EXT4_ORPHAN_FS; > ext4_orphan_cleanup(sb, es); > EXT4_SB(sb)->s_mount_state &= ~EXT4_ORPHAN_FS; > -- > 1.5.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
