On Sun, Apr 26, 2009 at 07:46:08AM -0400, Theodore Tso wrote: > That's true, but the patch also takes out the release/reacquire in in > ext4_remount (which was particularly ugly, belch). Sorry, missed the second hunk of the patch. > So even if > write_super gets called on an r/o filesystem (why?!?), No good reason really. Hopefully we'll sort all that out soon. > we should be > safe because remount will hold lock_super() throughout the entire > remount operation. > > We could delay this cleanup until you clean the mess with write_super, > but I don't think it would be harmful in removing the > lock_super()/unlock_super() pair in ext4_mark_recovery_complete(), and > the unlock_super()/lock_super() pair in ext4_remount before then. Am > I missing something? No, I was just missing the second hunk of the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
