On Mon, Nov 24, 2008 at 10:21:05AM -0800, Curt Wohlgemuth wrote: > > [ Sorry: I mistakenly sent just the patch, with no explanation... ] > > I happened to find a bug running bonnie++-1.03a on an ext4 filesystem, when > it complained about not being able to remove a file. > > Further investigation showed a problem with call_filldir(), which is not > quite correct with respect to the same function in fs/ext3/dir.c. The patch > below fixes this problem. Um, how much testing have you done with this patch in place? The change to call_filldir() was part of other changes in how call_filldir() was called, and at least in the common case where filldir() returns -EINVAL because there's not enough room in the user's readdir buffer and the entry needs to be saved for the next getdents() systemcall, the code is correct. In fact, I haven't tried your patch, but I'm pretty certain that if applied, it will cause directory entries to be dropped such that rm -rf for large hierarchies will *always* fail because some files won't get deleted becuase they won't be returned by readdir(). What kernel version were you running when you were testing ext4 using bonnie? If you are using a kernel older than 2.6.28-rc2 (and newer than 2.6.27-rc4), I would guess what you ran into was a known bug that was fixed by commit 3c37fc86. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
