[ Sorry: I mistakenly sent just the patch, with no explanation... ] I happened to find a bug running bonnie++-1.03a on an ext4 filesystem, when it complained about not being able to remove a file. Further investigation showed a problem with call_filldir(), which is not quite correct with respect to the same function in fs/ext3/dir.c. The patch below fixes this problem. Signed-off-by: Curt Wohlgemuth <curtw@xxxxxxxxxx> --- diff -Naur ext4/fs/ext4/dir.c b/fs/ext4/dir.c --- ext4/fs/ext4/dir.c 2008-11-13 14:51:58.000000000 -0800 +++ b/fs/ext4/dir.c 2008-11-24 08:23:05.000000000 -0800 @@ -417,7 +417,7 @@ get_dtype(sb, fname->file_type)); if (error) { filp->f_pos = curr_pos; - info->extra_fname = fname; + info->extra_fname = fname->next; return error; } fname = fname->next; -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html