Re: [RFC PATCH -v2 8/9] ext4: Fix double free of blocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 03, 2008 at 11:06:08PM +0530, Aneesh Kumar K.V wrote:
> blocks freed but not yet committed will be marked free
> in disk bitmap. We need to consider them as used when
> releasing inode prealloc space. Otherwise we would
> double free them via mb_free_blocks

Stupid question...   

Blocks that are added to an inode's preallocation list were initially
free, right?  And once they are in the inode's preallocation they are
marked in use by mballoc, so they can't be allocated for another
inode.  If a block in the preallocation list is used, it's removed
from the preallocation line.  So even if that inode is subsequented
unlinked or truncated, I'm curious how the double free situation
happens in the first place.

What am I missing?

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux