Eric Sandeen wrote:
> Aneesh Kumar K.V wrote:
>
>
>> The extent support on powerpc doesn't seems to work with e2fsprogs.
>> make check on e2fsprogs on powerpc gives
>>
>> f_extents: basic extents support: failed
>>
>>
> I see a few things wrong:
>
> Looks like swap_inode_full was incorrectly swapping the i_block
> data for extents, as well as incorrectly checking for the
> EXTENTS flag on big-endian boxes. Hmm maybe I need to think
> a little more about symlinks with the extent flag set...
>
FWIW, here's a patch for these problems. Still working on a clean
solution for the last one.
-Eric
Index: e2fsprogs/lib/ext2fs/swapfs.c
===================================================================
--- e2fsprogs.orig/lib/ext2fs/swapfs.c
+++ e2fsprogs/lib/ext2fs/swapfs.c
@@ -147,6 +147,7 @@ void ext2fs_swap_inode_full(ext2_filsys
int bufsize)
{
unsigned i, has_data_blocks, extra_isize, attr_magic;
+ int has_extents = 0;
int islnk = 0;
__u32 *eaf, *eat;
@@ -172,12 +173,13 @@ void ext2fs_swap_inode_full(ext2_filsys
has_data_blocks = ext2fs_inode_data_blocks(fs,
(struct ext2_inode *) t);
if (hostorder && (f->i_flags & EXT4_EXTENTS_FL))
- has_data_blocks = 0;
+ has_extents = 1;
t->i_flags = ext2fs_swab32(f->i_flags);
- if (hostorder && (t->i_flags & EXT4_EXTENTS_FL))
- has_data_blocks = 0;
+ if (!hostorder && (t->i_flags & EXT4_EXTENTS_FL))
+ has_extents = 1;
t->i_dir_acl = ext2fs_swab32(f->i_dir_acl);
- if (!islnk || has_data_blocks ) {
+ /* extent data are swapped on access, not here */
+ if (!has_extents && (!islnk || has_data_blocks)) {
for (i = 0; i < EXT2_N_BLOCKS; i++)
t->i_block[i] = ext2fs_swab32(f->i_block[i]);
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
